search

apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.15k stars 987 forks source link

fix(bin/create): set failing exit code on failure #1170

Closed raphinesse closed 2 years ago

raphinesse commented 2 years ago

Set failing exit code on failure for bin/create, like we do for the other binaries.

codecov-commenter commented 2 years ago

Codecov Report

Merging #1170 (2cf2fbc) into master (e20afdc) will increase coverage by 74.95%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1170       +/-   ##
===========================================
+ Coverage        0   74.95%   +74.95%     
===========================================
  Files           0       14       +14     
  Lines           0     1705     +1705     
===========================================
+ Hits            0     1278     +1278     
- Misses          0      427      +427
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/Podfile.js 73.20% <0.00%> (ø)
bin/templates/scripts/cordova/lib/prepare.js 85.00% <0.00%> (ø)
bin/templates/scripts/cordova/lib/listDevices.js 100.00% <0.00%> (ø)
...emplates/scripts/cordova/lib/listEmulatorImages.js 100.00% <0.00%> (ø)
bin/templates/scripts/cordova/lib/projectFile.js 94.91% <0.00%> (ø)
bin/templates/scripts/cordova/lib/run.js 19.62% <0.00%> (ø)
...in/templates/scripts/cordova/lib/BridgingHeader.js 95.45% <0.00%> (ø)
bin/templates/scripts/cordova/lib/check_reqs.js 45.09% <0.00%> (ø)
bin/templates/scripts/cordova/lib/versions.js 100.00% <0.00%> (ø)
...ates/scripts/cordova/lib/plugman/pluginHandlers.js 90.05% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e20afdc...2cf2fbc. Read the comment docs.