search

apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.15k stars 987 forks source link

dep!(dev): bump eslint w/ corrections #1182

Closed erisu closed 2 years ago

erisu commented 2 years ago

Motivation and Context

Update Eslint Config with Fixes

Description

Testing

Checklist

codecov-commenter commented 2 years ago

Codecov Report

Merging #1182 (1528ae2) into master (ea9751b) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1182   +/-   ##
=======================================
  Coverage   75.03%   75.03%           
=======================================
  Files          13       13           
  Lines        1650     1650           
=======================================
  Hits         1238     1238           
  Misses        412      412
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/Podfile.js 73.20% <100.00%> (ø)
...emplates/scripts/cordova/lib/listEmulatorImages.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea9751b...1528ae2. Read the comment docs.

raphinesse commented 2 years ago

I just remembered that we only enforce ES5 for browser code that lives in cordova-js. We could actually migrate the cordova-js-src that lives in this repo to ES6 (or beyond) if we can guarantee that it is supported by the iOS WebView versions we support. Is that the case?

So I think we should not disable the no-var rule in @cordova/eslint-config, since a platform should be able to decide whether it needs to support ES5-only environments or not.

Nevertheless this PR is still good to go for me (maybe remove my TODO if you agree with the above).