apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.15k stars 987 forks source link

refactor(versions): DRY version binary code #1185

Closed raphinesse closed 2 years ago

raphinesse commented 2 years ago

Motivation and Context

This removes some minor code smells from the versions module and binaries.

Description

Testing

codecov-commenter commented 2 years ago

Codecov Report

Merging #1185 (14436f6) into master (ea9751b) will decrease coverage by 0.16%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1185      +/-   ##
==========================================
- Coverage   75.03%   74.86%   -0.17%     
==========================================
  Files          13       13              
  Lines        1650     1655       +5     
==========================================
+ Hits         1238     1239       +1     
- Misses        412      416       +4     
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/versions.js 90.47% <33.33%> (-9.53%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea9751b...14436f6. Read the comment docs.