search

apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.16k stars 989 forks source link

feat(versions): print error messages, not error objects #1186

Closed raphinesse closed 2 years ago

raphinesse commented 2 years ago

Description

Only log error messages instead of the whole error objects in case of failure. This improves output especially for child process errors.

Testing

Manual testing

codecov-commenter commented 2 years ago

Codecov Report

Merging #1186 (118e31f) into master (d063f44) will decrease coverage by 0.04%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1186      +/-   ##
==========================================
- Coverage   74.86%   74.81%   -0.05%     
==========================================
  Files          13       13              
  Lines        1655     1656       +1     
==========================================
  Hits         1239     1239              
- Misses        416      417       +1
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/versions.js 88.37% <33.33%> (-2.11%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d063f44...118e31f. Read the comment docs.