apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.15k stars 987 forks source link

refactor!: cleanup create script #1191

Closed erisu closed 2 years ago

erisu commented 2 years ago

Motivation, Context & Description

This PR refactors the create script.

Testing

Checklist

codecov-commenter commented 2 years ago

Codecov Report

Merging #1191 (64e8a09) into master (6396343) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1191   +/-   ##
=======================================
  Coverage   75.15%   75.15%           
=======================================
  Files          13       13           
  Lines        1658     1658           
=======================================
  Hits         1246     1246           
  Misses        412      412           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6396343...64e8a09. Read the comment docs.

erisu commented 2 years ago

I am currently not sure why it is failing. I am able to run the testst locally and build a project without issues.

erisu commented 2 years ago

Conflicted and broken will redo the entire PR from scratch Monday.

raphinesse commented 2 years ago

I did some further cleanup when reviewing the remaining changes. I'll post that as a new PR ASAP. Hopefully tomorrow. So no need to redo this one for now.