Closed erisu closed 2 years ago
Merging #1191 (64e8a09) into master (6396343) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #1191 +/- ##
=======================================
Coverage 75.15% 75.15%
=======================================
Files 13 13
Lines 1658 1658
=======================================
Hits 1246 1246
Misses 412 412
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6396343...64e8a09. Read the comment docs.
I am currently not sure why it is failing. I am able to run the testst locally and build a project without issues.
Conflicted and broken will redo the entire PR from scratch Monday.
I did some further cleanup when reviewing the remaining changes. I'll post that as a new PR ASAP. Hopefully tomorrow. So no need to redo this one for now.
Motivation, Context & Description
This PR refactors the
create
script.updateSubprojectHelp
update_cordova_subproject
update_cordova_subproject
toupdateCordovaSubproject
updateCordovaSubproject
to take in two static arguments:projectXcodePath
which is the path to project's xcodeprojcordovaLibXcodePath
which is the path to the CordovaLib's xcodeproj. (Note: it maybe a symbolic link when--link
flag is added when installing platform)AbsParentPath
AbsProjectPath
relpath
updateSubprojectHelp
copyScript
copySync
apple-*
. No longer support the platform-centric so the files can be hardcoded for CLI.copyTemplateFiles
tocopyNativeTemplateFiles
bin/templates/project
totemplates/project
Testing
npm t
platform add
platform add
Checklist