apache / cordova-ios

Apache Cordova iOS

https://cordova.apache.org/

Apache License 2.0

2.15k stars 987 forks source link

build: build cordova.js during npm prepare #1192

Closed erisu closed 2 years ago

erisu commented 2 years ago

Motivation and Context

This will build cordova.js from source using npm's prepare hook.

Description

build cordova.js from source using npm's prepare hook
copy prepared cordova.js before running Java tests
delete and ignore the two prebuilt cordova.js files we had
do not bundle cordova-js-src anymore, since support for browserify builds has been discontinued for a while now

Testing

npm t
cordova platform add
cordova build

codecov-commenter commented 2 years ago

Codecov Report

Merging #1192 (7da53bd) into master (6396343) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1192   +/-   ##
=======================================
  Coverage   75.15%   75.15%           
=======================================
  Files          13       13           
  Lines        1658     1658           
=======================================
  Hits         1246     1246           
  Misses        412      412

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6396343...7da53bd. Read the comment docs.

erisu commented 2 years ago

Conflicted and broken will redo the entire PR from scratch Monday.

raphinesse commented 2 years ago

Since I caused the conflicts, I can of course rebase this PR. If that is OK with you