Closed raphinesse closed 2 years ago
I would actually argue that this change is not actually breaking, since I would not consider the removed module exports public API.
Merging #1193 (0087bcc) into master (6396343) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #1193 +/- ##
=======================================
Coverage 75.15% 75.15%
=======================================
Files 13 13
Lines 1658 1658
=======================================
Hits 1246 1246
Misses 412 412
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6396343...0087bcc. Read the comment docs.
Motivation and Context
This takes the changes from the first four commits of #1191 and adds a few further simplifications in the affected code areas.
I pulled this out to reduce the scope of said PR and since I already reviewed this part of the changes.
Description
From #1191:
updateSubprojectHelp
update_cordova_subproject
update_cordova_subproject
toupdateCordovaSubproject
updateCordovaSubproject
to take in two static arguments:projectXcodePath
which is the path to project's xcodeprojcordovaLibXcodePath
which is the path to the CordovaLib's xcodeproj. (Note: it maybe a symbolic link when--link
flag is added when installing platform)AbsParentPath
AbsProjectPath
relpath
updateSubprojectHelp
New:
copyJsAndCordovaLib
Testing
npm t