apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.15k stars 987 forks source link

refactor: cleanup create script #1193

Closed raphinesse closed 2 years ago

raphinesse commented 2 years ago

Motivation and Context

This takes the changes from the first four commits of #1191 and adds a few further simplifications in the affected code areas.

I pulled this out to reduce the scope of said PR and since I already reviewed this part of the changes.

Description

From #1191:

New:

Testing

npm t

raphinesse commented 2 years ago

I would actually argue that this change is not actually breaking, since I would not consider the removed module exports public API.

codecov-commenter commented 2 years ago

Codecov Report

Merging #1193 (0087bcc) into master (6396343) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1193   +/-   ##
=======================================
  Coverage   75.15%   75.15%           
=======================================
  Files          13       13           
  Lines        1658     1658           
=======================================
  Hits         1246     1246           
  Misses        412      412           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6396343...0087bcc. Read the comment docs.