search

apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.15k stars 987 forks source link

Not all icons provided in config.xml are being used #1233

Open Birowsky opened 2 years ago

Birowsky commented 2 years ago

Bug Report

Problem

Cordova doesn't utilize all icons provided in config.xml.

What is expected to happen?

Cordova should use all provided icons and adds them to XCode here:

Screen Shot 2022-05-02 at 1 13 04 PM

What does actually happen?

The icons that do not have Cordova placeholders do not get updated.

Information

I provide all icons sizes as described in the Cordova documentation here. I also provide icons sizes as described in XCode specs, that are outside of the cordova docs. Here's part of my config.xml:

...
<icon src="resources/ios/icon/icon-50.png" width="50" height="50" />
<icon src="resources/ios/icon/icon-50@2x.png" width="100" height="100" />
<icon src="resources/ios/icon/icon-83.5@2x.png" width="167" height="167" />
<icon src="resources/ios/icon/icon-1024.png" width="1024" height="1024" />
<icon src="resources/ios/icon/icon-20.png" width="20" height="20" />
<icon src="resources/ios/icon/icon-48.png" width="48" height="48" />
<icon src="resources/ios/icon/icon-55.png" width="55" height="55" />
<icon src="resources/ios/icon/icon-66.png" width="66" height="66" />
<icon src="resources/ios/icon/icon-88.png" width="88" height="88" />
<icon src="resources/ios/icon/icon-92.png" width="92" height="92" />
<icon src="resources/ios/icon/icon-102.png" width="102" height="102" />
<icon src="resources/ios/icon/icon-172.png" width="172" height="172" />
<icon src="resources/ios/icon/icon-196.png" width="196" height="196" />
...

With this approach, all icons get updated, except the ones that do not have templates by Cordova. A similar issue has been reported here, but I hope my description nicely generalizes it.

Checklist