vbraun commented 1 year ago

Platforms affected

iOS 16

Motivation and Context

iOS 16 breaks DisallowOverscroll setting, this PR adds workaround discussed in https://github.com/apache/cordova-ios/issues/1244

Description

Disabling both webView.scrollView.bounce and webView.scrollView.alwaysBounceVertical

Testing

Manually tested on iOS 15 and iOS 16

Checklist

[ ] I've run the tests to see all new and existing tests pass
[ ] I added automated test coverage as appropriate for this change
[X] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[X] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[ ] I've updated the documentation if necessary

Closes #1244

vbraun commented 1 year ago

Good point, added.

codecov-commenter commented 1 year ago

Codecov Report

Merging #1258 (f192df1) into master (af7512a) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1258   +/-   ##
=======================================
  Coverage   78.26%   78.26%           
=======================================
  Files          15       15           
  Lines        1767     1767           
=======================================
  Hits         1383     1383           
  Misses        384      384

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

u01jmg3 commented 1 year ago

@dpogue when do you intend to release 6.2.1?