apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.15k stars 987 forks source link

feat: Add support for Apple Cloud Distribution signing #1276

Closed dpogue closed 1 year ago

dpogue commented 1 year ago

Platforms affected

iOS

Motivation and Context

This enables automatic provisioning with Apple Cloud Distribution certificates (which is really useful for cloud CI systems).

Description

This adds 3 new properties that can be specified on the command-line or via build.json, matching the 3 properties that need to be passed to xcodebuild to allow automatic cloud signing.

I have some notes about how this works and how I set up automatic signing with GitHub Actions for a non-Cordova project here: https://gist.github.com/dpogue/d11df53cca6ba0e23d14d674ee5f9762

Testing

Unit tests updated, still needs some further testing.

Checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #1276 (67fcc0d) into master (8ed0c08) will increase coverage by 0.20%. The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master    #1276      +/-   ##
==========================================
+ Coverage   78.26%   78.47%   +0.20%     
==========================================
  Files          15       15              
  Lines        1767     1784      +17     
==========================================
+ Hits         1383     1400      +17     
  Misses        384      384              
Impacted Files Coverage Δ
lib/build.js 67.02% <87.50%> (+3.33%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more