apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.15k stars 987 forks source link

WIP: Better Catalyst build support #1313

Open dpogue opened 1 year ago

dpogue commented 1 year ago

Platforms affected

iOS, macOS

Motivation and Context

With the deprecation of cordova-osx and the availability of Catalyst to deploy iOS apps on macOS as their own app bundles, we should support targeting Catalyst builds.

Description

After the work in #1310 caused the build output folder to be named based on the platform, I realized this actually solved one of the remaining questions around where to put Catalyst output files... now they end up in build/Debug-maccatalyst or build/Release-maccatalyst

We detect if we are building for Catalyst (as opposed to iOS Device vs iOS Simulator) by the --target=mac option.

Testing

cordova build ios --target=mac works cordova run ios --target=mac works

Checklist

codecov-commenter commented 1 year ago

Codecov Report

Attention: Patch coverage is 23.33333% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 77.93%. Comparing base (f7e2953) to head (368f216).

Files Patch % Lines
lib/run.js 5.26% 18 Missing :warning:
lib/build.js 54.54% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1313 +/- ## ========================================== - Coverage 78.35% 77.93% -0.43% ========================================== Files 16 16 Lines 1825 1840 +15 ========================================== + Hits 1430 1434 +4 - Misses 395 406 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.