Open dpogue opened 1 year ago
Attention: Patch coverage is 23.33333%
with 23 lines
in your changes are missing coverage. Please review.
Project coverage is 77.93%. Comparing base (
f7e2953
) to head (368f216
).
Files | Patch % | Lines |
---|---|---|
lib/run.js | 5.26% | 18 Missing :warning: |
lib/build.js | 54.54% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Platforms affected
iOS, macOS
Motivation and Context
With the deprecation of cordova-osx and the availability of Catalyst to deploy iOS apps on macOS as their own app bundles, we should support targeting Catalyst builds.
Description
After the work in #1310 caused the build output folder to be named based on the platform, I realized this actually solved one of the remaining questions around where to put Catalyst output files... now they end up in
build/Debug-maccatalyst
orbuild/Release-maccatalyst
We detect if we are building for Catalyst (as opposed to iOS Device vs iOS Simulator) by the
--target=mac
option.Testing
cordova build ios --target=mac
workscordova run ios --target=mac
worksChecklist