fix(splashscreen): positioning after rotation

apache / cordova-ios

Apache Cordova iOS

https://cordova.apache.org/

Apache License 2.0

2.15k stars 987 forks source link

fix(splashscreen): positioning after rotation #1315

Closed dpogue closed 1 year ago

dpogue commented 1 year ago

Platforms affected

ios

Motivation and Context

Closes #1231.

Description

Add constraints to the splashscreen view so that it keeps the aspect ratio and positioning when the device is rotated.

@goffioul This is mostly the code that you proposed, do you want to be credited on the commit for this?

Testing

Tested on an iOS Simulator.

Checklist

[x] I've run the tests to see all new and existing tests pass
[x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

codecov-commenter commented 1 year ago

Codecov Report

Merging #1315 (642ce20) into master (3d6c71a) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1315   +/-   ##
=======================================
  Coverage   78.48%   78.48%           
=======================================
  Files          15       15           
  Lines        1780     1780           
=======================================
  Hits         1397     1397           
  Misses        383      383

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

goffioul commented 1 year ago

@dpogue You created this PR, but I would indeed appreciate partial credit. Thanks for asking.