apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.15k stars 987 forks source link

chore!: Remove podspec support from framework tag #1340

Closed dpogue closed 1 year ago

dpogue commented 1 year ago

Closes #812.

Platforms affected

iOS

Motivation and Context

<framework type="podspec"> has been deprecated in favour of the <podspec> tag that allows much more control over pod dependencies.

Description

Remove support for <framework type="podspec"> and print an error if such framework tags are found.

Testing

Removed unit tests around special case handling for podspec framework tags.

Checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #1340 (7445c88) into master (98910de) will decrease coverage by 0.04%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
- Coverage   78.62%   78.58%   -0.04%     
==========================================
  Files          15       15              
  Lines        1801     1770      -31     
==========================================
- Hits         1416     1391      -25     
+ Misses        385      379       -6     
Impacted Files Coverage Δ
lib/plugman/pluginHandlers.js 89.69% <0.00%> (-0.47%) :arrow_down:
lib/Api.js 71.11% <100.00%> (-0.88%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more