apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.15k stars 986 forks source link

refactor!: Remove scrollView category extension on UIView #1400

Open dpogue opened 2 months ago

dpogue commented 2 months ago

🚨 BREAKING API CHANGE! This should be tested with all the core plugins, just in case any of them are relying on this API existing.

Platforms affected

iOS

Motivation and Context

As mentioned in #1399, this API was added as a compatibility shim at the time we supported both UIWebView and WKWebView, when WKWebView did not expose a public scrollView property. That property was made available in iOS 8, and this extension now risks causing problems due to being applied globally to all UIView subclasses.

Closes #1399.

Description

Remove the category extension to expose a scrollView property on all UIView object instances.

Testing

...

Checklist

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (92017bb) 78.25% compared to head (f7d069d) 78.25%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1400 +/- ## ======================================= Coverage 78.25% 78.25% ======================================= Files 15 15 Lines 1789 1789 ======================================= Hits 1400 1400 Misses 389 389 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.