Closed dpogue closed 7 months ago
Attention: Patch coverage is 86.56716%
with 9 lines
in your changes are missing coverage. Please review.
Project coverage is 78.47%. Comparing base (
1974dbb
) to head (7ddec78
).
Files | Patch % | Lines |
---|---|---|
lib/prepare.js | 75.00% | 3 Missing :warning: |
lib/run.js | 50.00% | 3 Missing :warning: |
lib/Api.js | 75.00% | 1 Missing :warning: |
lib/build.js | 85.71% | 1 Missing :warning: |
lib/plugman/pluginHandlers.js | 92.85% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Platforms affected
iOS
Motivation and Context
This allows us to drop the
fs-extra
andunorm
library by replacing their use with built-in NodeJS standard library calls.Description
unorm
module withString.prototype.normalize
fs-extra
usage with equivalent NodeJSfs
callswhich
to latest versionpath.join
in a bunch of spots where we're constructing pathsnopt
dependencyTesting
Checklist