Closed dpogue closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 80.22%. Comparing base (
f3339a9
) to head (26872aa
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Platforms affected
ios
Motivation and Context
Some of the code in CordovaLib dates back to the very early dates of cordova-ios and an era when iOS 4 introduced breaking changes and Objective C was having new language features introduced (yes, Cordova actually predates the transition to ObjC ARC 💀).
Nowadays there are some conventions that are pretty standard (like
instancetype
for initializer methods) that we should aim to adopt for consistency.Also, refactored
CDVConfigParser
to avoid needing a round-trip through weirdCDVViewController
methods to do anything useful. I can split this commit out into its own PR if that makes it easier for review.Description
CDVConfigParser
to facilitate parsing config.xmlTesting
All existing unit tests pass.
Checklist