apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.16k stars 986 forks source link

refactor: Reorder methods in CDVViewController #1475

Closed dpogue closed 3 months ago

dpogue commented 3 months ago

Platforms affected

iOS

Motivation and Context

Methods in CDVViewController are spread all over with no logical grouping to make them easier to find.

Description

This gives them a much more logical grouping.

Testing

All existing tests passed (no functional change, just moving functions around)

Checklist

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.22%. Comparing base (27a6068) to head (6d57b9a). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1475 +/- ## ======================================= Coverage 80.22% 80.22% ======================================= Files 16 16 Lines 1871 1871 ======================================= Hits 1501 1501 Misses 370 370 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.