search

apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.15k stars 986 forks source link

CB-10962 CB-10945 removes justlaunch flag waiting for a fix in ios-deploy #212

Closed akofman closed 8 years ago

omefire commented 8 years ago

This works, but it brings us back to when we used to have to exit lldb manually.

omefire commented 8 years ago

I'd prefer this PR be merged into ios-deploy: https://github.com/phonegap/ios-deploy/pull/218 That way, we wouldn't have to fix this issue here.

akofman commented 8 years ago

Sure I 100% agree with that. That's why I asked to @shazron what he thinks. If we have to wait 6 months more, I think it's better to keep something working instead of the actual situation.

omefire commented 8 years ago

The thing is that this used to work just fine. Some recent changes might have broken it.

akofman commented 8 years ago

Maybe it's related to the last XCode updates. What version are you using ?

omefire commented 8 years ago

I'm using XCode Version 7.3 (7D175)

omefire commented 8 years ago

I tested the following PR: https://github.com/phonegap/ios-deploy/pull/218 and unfortunately, it didn't fix the issue for me.

akofman commented 8 years ago

hmmmm indeed.

omefire commented 8 years ago

Could it be XCode update(from 7.2 to 7.3) that is causing this issue ?

akofman commented 8 years ago

I think it's more than possible.

akofman commented 8 years ago

XCode 7.2 is using lldb-340.4.119.1 while XCode 7.3 is using lldb-350.0.21.3.

omefire commented 8 years ago

Hmmm, interesting

omefire commented 8 years ago

I think we should pull this in, while waiting for a fix for the XCode 7.3 issue. What do you think @shazron ? Because as it currently stands, people with the latest XCode can't deploy to their devices.

shazron commented 8 years ago

This change will modify expected behaviour if someone is scripting this, since the run call will not terminate. That is, however, a lower priority consequence versus fixing this bug right now. I'll investigate a fix for ios-deploy for today, if there is no progress, we should proceed with this change.

omefire commented 8 years ago

OK, sounds good. I'm running some investigations as well.

shazron commented 8 years ago

Update (good news?): https://github.com/phonegap/ios-deploy/pull/218#issuecomment-206597622

shazron commented 8 years ago

Everyone, try the new ios-deploy version 1.8.6. This PR can be closed.