search

apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.16k stars 989 forks source link

Why do we depend on a global ios-deploy? #419

Open oliversalzburg opened 5 years ago

oliversalzburg commented 5 years ago

Why can't ios-deploy be installed locally?

janpio commented 5 years ago

Weren't there problem with installing packages locally with npm on Windows and then being able to execute them? Most CLI like tools installed via npm used to use -g as an option...

oliversalzburg commented 5 years ago

@janpio Yes, I think there were issues in the past, but those should really be in the past. Executable npm modules should all register entrypoints in node_modules/.bin/ and should generally be easily invokable from there. If everything else fails, I think npx is widely accepted as a solution in this regard.

janpio commented 5 years ago

Afaik Cordova support much older versions of node/npm than those that first added a stable version of npx.

But in general it would of course be better, to have a local dependency on ios-deploy than the current state. Could also get rid of that code that gives you the error message then. I think we would be very happy in merging a PR that changes this.

brodycj commented 5 years ago

There were 2 reasons we did not explicitly depend on ios-deploy in the past ([1]):

[1] https://lists.apache.org/thread.html/8f01ff201d46dce3fadec5479fd715b96f8b366aac38b4dd2cdfe411@%3Cdev.cordova.apache.org%3E

brodycj commented 5 years ago

Viral license was especially bad in the past when "we" had to include dependencies in the bundle. (I was not part of the "we" before 2018.)

This should no longer be necessary in next major release where we are dropping Node.js 4 support. But it may still be an issue to add such a dependency in an Apache project. I would also personally downvote such an explicit dependency due to the viral license.

Sorry I took so long to compose the response.

oliversalzburg commented 5 years ago

@brodybits You would be opposed to adding an ios-deploy dependency to cordova because ios-deploy uses a problematic license? Why? And why is it then fine to still rely on it?

Sorry, just read https://github.com/apache/cordova-ios/issues/420#issuecomment-425102077, which already makes it a bit clearer. I would still love to hear your reasoning behind it though.