apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.16k stars 987 forks source link

breaking: add & use fs-extra w/ fixes #847

Closed erisu closed 4 years ago

erisu commented 4 years ago

Motivation, Context & Description

Testing

Checklist

codecov-commenter commented 4 years ago

Codecov Report

Merging #847 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #847   +/-   ##
=======================================
  Coverage   74.40%   74.40%           
=======================================
  Files          13       13           
  Lines        1821     1821           
=======================================
  Hits         1355     1355           
  Misses        466      466           
Impacted Files Coverage Δ
bin/templates/scripts/cordova/Api.js 71.42% <100.00%> (ø)
...in/templates/scripts/cordova/lib/BridgingHeader.js 95.45% <100.00%> (ø)
bin/templates/scripts/cordova/lib/Podfile.js 73.58% <100.00%> (ø)
bin/templates/scripts/cordova/lib/PodsJson.js 95.04% <100.00%> (ø)
bin/templates/scripts/cordova/lib/build.js 50.76% <100.00%> (ø)
...ates/scripts/cordova/lib/plugman/pluginHandlers.js 90.20% <100.00%> (ø)
bin/templates/scripts/cordova/lib/prepare.js 82.05% <100.00%> (ø)
bin/templates/scripts/cordova/lib/projectFile.js 94.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aae6a86...d96a131. Read the comment docs.

timbru31 commented 4 years ago

Replace test spec xml generating logic and use pre-made xml test fixtures. Lower the amount of call mocks with actual tool usage for improved testing.

Very nice!