apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.16k stars 987 forks source link

revert: ios-sim ^9.0.0 to ^8.0.2 #862

Closed erisu closed 4 years ago

erisu commented 4 years ago

Motivation and Context

  '          this.log(`logPath: ${path.resolve(flags.log)}`)\n' +
  '               ^\n' +
  '\n' +
  "TypeError: Cannot read property 'log' of undefined\n" +

Description

Testing

Checklist

codecov-commenter commented 4 years ago

Codecov Report

Merging #862 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #862   +/-   ##
=======================================
  Coverage   74.40%   74.40%           
=======================================
  Files          13       13           
  Lines        1821     1821           
=======================================
  Hits         1355     1355           
  Misses        466      466           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 43e3bbd...faf5cf8. Read the comment docs.

erisu commented 4 years ago

Last call on review, this PR will be merged in tomorrow for release.

On top of the scoping issue within ios-sim 9.x, if fixed, the logging to file feature is not implemented it appears as it does not write to the provided log path.