Closed NiklasMerz closed 4 years ago
Merging #886 into master will increase coverage by
1.89%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #886 +/- ##
==========================================
+ Coverage 74.40% 76.30% +1.89%
==========================================
Files 13 13
Lines 1676 1941 +265
==========================================
+ Hits 1247 1481 +234
- Misses 429 460 +31
Impacted Files | Coverage Δ | |
---|---|---|
bin/templates/scripts/cordova/lib/prepare.js | 86.60% <0.00%> (+1.19%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 02448ce...d27a366. Read the comment docs.
Platforms affected
iOS
Motivation and Context
This adds a prefrence to the webview which is useful for iPads. Apple introduced a setting which by defaults changes the useragent of iPads from
iPad
toMacintosh
to provide a "desktop browsing experience". The new preference allows to change the default value.See original issue from IAB: apache/cordova-plugin-inappbrowser#687
Description
Changed like : apache/cordova-plugin-inappbrowser#688
Documenation: https://github.com/apache/cordova-docs/pull/1083
Testing
Automatic tests still pass. I found no automatic tests for preferences at build time.
I created a blank new app, added this platform and checked
navigator.userAgent
while changing the preference. It should beiPad
formobile
andMacintosh
fordesktop
.Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)