apache / cordova-lib

Apache Cordova Tooling Library
https://cordova.apache.org/
Apache License 2.0
221 stars 243 forks source link

feat(windows): deprecate platform #852

Closed brodycj closed 2 years ago

brodycj commented 4 years ago

Status

Platforms affected

Windows

Motivation and Context

see this discussion in dev@cordova.apache.org

Description

set "deprecated": true for Windows in src/platforms/platformsConfig.json

Testing

updated:

In a local checkout of cordova-cli:

npm i github:apache/cordova-lib#brodybits-windows-deprecated
./bin/cordova create test1
cd test1

after adding Windows, ../bin/cordova platform ls gives me the following output:

Warning: using prerelease version 10.0.1-dev (cordova-lib@10.0.1-dev)
Installed platforms:
  windows 7.0.1 (deprecated)
Available platforms: 
  android ^9.0.0
  browser ^6.0.0
  electron ^1.0.0
  ios ^6.1.0
  osx ^6.0.0

Checklist

erisu commented 2 years ago

Cordova-Windows deprecation notice was already posted to the repo and also Cordova website reflects it.

https://github.com/apache/cordova-windows/commit/0454321fec629741375d8964a921b4a4d91e4df7

erisu commented 2 years ago

I have rebased this PR.

erisu commented 2 years ago

@brodybits thank you for the PR

codecov-commenter commented 2 years ago

Codecov Report

Merging #852 (9368657) into master (42b4569) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #852   +/-   ##
=======================================
  Coverage   88.27%   88.27%           
=======================================
  Files          46       46           
  Lines        2123     2123           
=======================================
  Hits         1874     1874           
  Misses        249      249           

Help us with your feedback. Take ten seconds to tell us how you rate us.