fix: add undeclared dependency `underscore` - Githubissues

apache / cordova-lib

Apache Cordova Tooling Library

https://cordova.apache.org/

Apache License 2.0

221 stars 243 forks source link

fix: add undeclared dependency `underscore` #869

Closed merceyz closed 3 years ago

merceyz commented 3 years ago

Platforms affected

All

Motivation and Context

cordova-lib depends on underscore but doesn't declare it as a dependency https://github.com/apache/cordova-lib/blob/5cc0a79b5897a62d25097233e9cbe89f41bb1264/src/cordova/serve.js#L24 https://github.com/apache/cordova-lib/blob/b9ad92a6693c2fe977309d17449fa95949c1f7c3/src/cordova/requirements.js#L20

It was declared correctly before but seems to have been removed in https://github.com/apache/cordova-lib/pull/772

Ref https://github.com/apache/cordova-ios/pull/1105

Description

Added underscore as a dependency

Testing

Ran cordova prepare under a strict dependency environment

Checklist

[ ] I've run the tests to see all new and existing tests pass
[ ] I added automated test coverage as appropriate for this change
[ ] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[x] I've updated the documentation if necessary

raphinesse commented 3 years ago

Thanks a lot for spotting this and bringing it up here! I would rather remove the hidden dependency on underscore than to declare it (see #871). But let's see if someone else has an opinion on that.