purplecabbage commented 3 years ago

Platforms affected

Motivation and Context

Description

Testing

Checklist

[ ] I've run the tests to see all new and existing tests pass
[ ] I added automated test coverage as appropriate for this change
[ ] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[ ] I've updated the documentation if necessary

codecov-commenter commented 3 years ago

Codecov Report

Merging #876 (d9b9448) into master (3274a78) will not change coverage. The diff coverage is n/a.

:exclamation: Current head d9b9448 differs from pull request most recent head ac657c1. Consider uploading reports for the commit ac657c1 to get more accurate results

@@           Coverage Diff           @@
##           master     #876   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files          45       45           
  Lines        2053     2053           
=======================================
  Hits         1871     1871           
  Misses        182      182

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3274a78...ac657c1. Read the comment docs.

raphinesse commented 3 years ago

@purplecabbage I tried switching to GH Actions too and hit that Windows incompatibility problem :unamused:. Unfortunately it was a hairy mess to fix that properly IIRC. But I think I still have some WIP for that. I can try to outline the problem as fas as I have identified it, if you want.