search

apache / cordova-lib

Apache Cordova Tooling Library
https://cordova.apache.org/
Apache License 2.0
221 stars 242 forks source link

refactor(addHelper): more concise package.json spec lookup #882

Closed raphinesse closed 2 years ago

raphinesse commented 3 years ago

Improves code and tests related to the code fixed in #874.

codecov-commenter commented 2 years ago

Codecov Report

Merging #882 (de47a92) into master (33ce4fe) will increase coverage by 0.07%. The diff coverage is 100.00%.

:exclamation: Current head de47a92 differs from pull request most recent head 8ecbe8a. Consider uploading reports for the commit 8ecbe8a to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
+ Coverage   91.13%   91.21%   +0.07%     
==========================================
  Files          45       45              
  Lines        2053     2048       -5     
==========================================
- Hits         1871     1868       -3     
+ Misses        182      180       -2
Impacted Files Coverage Δ
src/cordova/platform/addHelper.js 95.91% <100.00%> (+1.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 33ce4fe...8ecbe8a. Read the comment docs.