Closed erisu closed 1 year ago
Merging #894 (34a93de) into master (b0de231) will decrease coverage by
0.03%
. The diff coverage is90.90%
.
@@ Coverage Diff @@
## master #894 +/- ##
==========================================
- Coverage 88.36% 88.33% -0.03%
==========================================
Files 46 46
Lines 2123 2118 -5
==========================================
- Hits 1876 1871 -5
Misses 247 247
Impacted Files | Coverage Δ | |
---|---|---|
src/cordova/platform/list.js | 95.45% <87.50%> (-0.85%) |
:arrow_down: |
src/cordova/platform/addHelper.js | 95.91% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Last call for review before merging.
Platforms affected
none
Motivation and Context
Description
Previous concerns which shouldnt not be an issue anymore: Platforms relied on the common object which was passed to platform. Platforms should now be recreating the common object using its own installed common package.
E.g.
Testing
In Progress
npm t
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)