erisu commented 2 years ago

Platforms affected

osx, windows

Motivation and Context

Deprecate OSX and Windows platform.

Description

Set the deprecation flag for OSX and Windows platform.

This can be released in minor release as a notice and then in 12.0.0 remove completely?

Testing

n/a

Checklist

[ ] I've run the tests to see all new and existing tests pass
[ ] I added automated test coverage as appropriate for this change
[ ] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[x] I've updated the documentation if necessary
- was already deprecated.

erisu commented 2 years ago

Actually, this PR can be closed for the two individual PRs I now see already submited.

codecov-commenter commented 2 years ago

Codecov Report

Merging #895 (3dae44d) into master (42b4569) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 3dae44d differs from pull request most recent head bd4d2f8. Consider uploading reports for the commit bd4d2f8 to get more accurate results

@@           Coverage Diff           @@
##           master     #895   +/-   ##
=======================================
  Coverage   88.27%   88.27%           
=======================================
  Files          46       46           
  Lines        2123     2123           
=======================================
  Hits         1874     1874           
  Misses        249      249

Help us with your feedback. Take ten seconds to tell us how you rate us.

apache / cordova-lib

feat: deprecate osx & windows platform #895