WIP: Updated cordova-common for the new framework link attribute.

TylerBreau commented 1 year ago

Platforms affected

iOS

Motivation and Context

This PR depends on https://github.com/apache/cordova-common/pull/179. This PR is to update the cordova-common package after https://github.com/apache/cordova-common/pull/179 is merged in.

This PR is required to update cordova-cli so that these changes can actually be used.

cordova-docs pr: https://github.com/apache/cordova-docs/pull/1267

Description

Updated cordova-common to https://github.com/apache/cordova-common/pull/179.

Testing

I've ran npm test.

Tested various combinations of framework tag's embed and link attributes by installing a plugin using these attributes. I would observe how the XCFramework is added to the the XCode project with the following focuses: -Is the XCFramework embedded (or not embedded) in Build Phrases? -Is the XCFramework linked (or not linked) in Build Phrases? -Is the XCFramework set to "Embed and Sign" in General?

I have ran my company's app using these changes.

I found 1 test failing in cordova-lib master. Naturally, since it failed on master and was not related to my changes, it was also failing on my branch.

pkgJson platform end-to-end with --save Test#012 : platform with local path is added correctly with --save
 - Unhandled promise rejection: TypeError: message.split is not a function
   at <Jasmine>
 - Error: Timeout - Async function did not complete within 150000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL)
   at <Jasmine>
   at listOnTimeout (node:internal/timers:559:17)
   at processTimers (node:internal/timers:502:7)

Checklist

[x] I've run the tests to see all new and existing tests pass
[x] I added automated test coverage as appropriate for this change
[x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[x] I've updated the documentation if necessary

TylerBreau commented 1 year ago

This change spans across 5 repositories. These are the 5 PRs:

dpogue commented 1 year ago

Going to close this because we definitely don't want to do updates by including tar.gz files committed to the repo.

apache / cordova-lib