apache / cordova-lib

Apache Cordova Tooling Library
https://cordova.apache.org/
Apache License 2.0
221 stars 242 forks source link

feat: bump cordova-common@4.1.0 #899

Closed TylerBreau closed 1 year ago

TylerBreau commented 1 year ago

Platforms affected

All

Note, all changes are backwards compatible.

Motivation and Context

When adding XML attributes to the XML tags, we currently need to update around 6 repos (cordova-common, cordova-lib, cordova-cli, platform repos, docs).

cordova-common 4.1.0 (https://github.com/apache/cordova-common/pull/181) fixes this by passing through all XML attributes.

In order for platforms to begin using cordova-common 4.1.0, the developer's cordova-cli must use cordova-common 4.1.0.

cordova-cli depends on cordova-lib and cordova-common. cordova-lib depends on cordova-common.

In order to ensure cordova-cli is always using the correct version of cordova-common, it would be safest to update cordova-lib first.

Description

This PR updates cordova-lib's cordova-common to 4.1.0.

Testing

I've added unit tests for XML passthrough in cordova-common.

I've ran npm test on cordova-common, cordova-lib, cordova-cli. lib and cli were updated with the cordova-common change. I've ran these changes on my company's app.

An update in my company's attribute is requiring me to add a new attribute to the framework tag. I've tested adding a new attribute to cordova-ios with my company's app using these changes.

I found 1 test failing in cordova-lib master. Naturally, since it failed on master and was not related to my changes, it was also failing on my branch.

pkgJson platform end-to-end with --save Test#012 : platform with local path is added correctly with --save

Checklist

erisu commented 1 year ago

I relabeled the title of this PR as the change is generic to a dependency upgrade and nothing else.

Even though the goal of the PR is for XML passthrough support, from recent common changes, there was nothing else specifically added in this PR in addition to the upgrade of the dependency for this support.