apache / cordova-lib

Apache Cordova Tooling Library
https://cordova.apache.org/
Apache License 2.0
221 stars 242 forks source link

feat!(run): call platform api to list targets #917

Closed erisu closed 1 year ago

erisu commented 1 year ago

Platforms affected

n/a

Motivation and Context

Prepare for the removal of calling binaries in the platform packages. Use the platform API to handle listing out of targets.

Description

This PR will call platformApi.listTargets when the platfrom api contains the method. To also support platforms that has not been updated, it will fallback and call the old binrary.

Testing

npm t

Checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #917 (1f2da0d) into master (1aa9193) will decrease coverage by 0.42%. The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #917      +/-   ##
==========================================
- Coverage   88.36%   87.94%   -0.42%     
==========================================
  Files          46       46              
  Lines        2123     2132       +9     
==========================================
- Hits         1876     1875       -1     
- Misses        247      257      +10     
Impacted Files Coverage Δ
src/cordova/run.js 70.58% <33.33%> (-29.42%) :arrow_down:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more