apache / cordova-mobile-spec

Apache Cordova mobile-spec
Apache License 2.0
66 stars 107 forks source link

add www/img/logo.png file in order to pass file.spec.147 tests #198

Closed knight9999 closed 5 years ago

knight9999 commented 5 years ago

Platforms affected

each platforms

Motivation and Context

createmobilespec command here creates a test project mobilespec. In that test project, the cordova-plugin-file-test plugin is added. (cordova-plugin-file-test is a part of cordova-plugin-file) test.js in cordova-plufin-file-tests checks /www/img/logo.png file exists or not, as

                    resolveLocalFileSystemURL('cdvfile://localhost/' + cdvfileApplicationDirectoryFsRootName + '/www/img/logo.png', function (entry) {
 ...

in file.spec.147.

Therefore the project must have a file www/img/logo.png file to pass the tests.

Description

This PR simply added www/img/logo.png file in order to pass the file.spec.147 in cordova-plugin-file-tests.

Testing

launching mobilespec project as

./cordova run android

in mobilespec directory. Confirm jasmine tests.

Checklist

janpio commented 5 years ago

Ah, seems the tests were written for the "hello world" Cordova app that includes this image by default. Interdependencies all the way...