apache / cordova-node-xcode

Apache cordova
Apache License 2.0
190 stars 97 forks source link

ci: switch travis ci for github actions #96

Closed erisu closed 4 years ago

erisu commented 4 years ago

Overall goal, unify services used across repo. Travis CI is a slow service during peak hours and its something that is unbearable. This is caused by the resources of the service is shared across all Apache projects. If people have limited time to review and/or do releases, waiting for tests should not be a bottleneck.

erisu commented 4 years ago

Per NPMJS:

It is highly recommended you commit the generated package lock to source control

Anyone using this library should install it though npm install xcode which does not use the package-lock.json as it is never bundled with the package.

NiklasMerz commented 4 years ago
* Commit `package-lock.json` PR: [apache/cordova#4](https://github.com/apache/cordova/issues/4)

Per NPMJS:

It is highly recommended you commit the generated package lock to source control

Anyone using this library should install it though npm install xcode which does not use the package-lock.json as it is never bundled with the package.

Thank you. I learned something new!

timbru31 commented 4 years ago

@NiklasMerz - FYI: https://github.com/apache/cordova/issues/4