Add args to build command used for Saucelabs as well - Githubissues

apache / cordova-paramedic

Apache Cordova - Paramedic

https://cordova.apache.org/

Apache License 2.0

36 stars 53 forks source link

Add args to build command used for Saucelabs as well #114

Closed gmotzespina closed 5 years ago

gmotzespina commented 5 years ago

Platforms affected

iOS

Motivation and Context

It fixes issue #113, it enables to run the plugin on SauceLabs.

Description

Concatenation of the passed arguments using the --args flag.

Testing

Running the following command and receiving success result,

npx cordova-paramedic --platform ios --plugin ./ --shouldUseSauce --sauceUser ****** --sauceKey ********** --buildName "local cordova-paramedic test for ios"  --outputDir /tmp/junit --verbose --args=--buildFlag='-UseModernBuildSystem=0'

Checklist

[X] I've run the tests to see all new and existing tests pass
[X] I added automated test coverage as appropriate for this change
[X] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[X] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[X] I've updated the documentation if necessary

close #113

janpio commented 5 years ago

Thanks for the PR @gmotzespina. Keep them coming :)