search

apache / cordova-paramedic

Apache Cordova - Paramedic
https://cordova.apache.org/
Apache License 2.0
36 stars 53 forks source link

Handle SauceLabs on forks of repos #135

Closed janpio closed 3 years ago

janpio commented 5 years ago

When someone forks this or one of the plugins repos using this, SauceLabs will not work as the jwt secure variable containing the sauce labs key will not be valid for that repo.

We could try to find a way to a) not fail in those scenarios or b) offer a workaround somehow, so that users can at least easily provider their own key.

timbru31 commented 5 years ago

Just dropping a random note: JWT addon is deprecated since >1 year on TravisCI (https://blog.travis-ci.com/2018-01-23-jwt-addon-is-deprecated).

Basically it could stop working any given day? (Quote: At the scheduled date of April 17, 2018, the addon will cease to function. )

janpio commented 5 years ago

Known issue, but obv. not written down anywhere, so I created: https://github.com/apache/cordova-paramedic/issues/136

timbru31 commented 5 years ago

b) offer a workaround somehow

SauceLabs needs an API key - so I doubt this is impossible without exposing the key to everyone :(

janpio commented 5 years ago

If travis.yml could read from a file, we could have a gitignored file or via ENV var for some environments. Maybe Travis allows overwriting those values via a repo specific ENV var? Something like this.

timbru31 commented 5 years ago

we could have a gitignored file

Since TravisCI clones the repo, how should this work?

ENV var for some environments

Define "some environments". Everything from outside the Apache org can read every ENV var, that's the problem :(

janpio commented 5 years ago

If everyone else besides Apache could use ENV vars to overwrite the JWT stuff, this could work. In my testing some time ago this unfortunately was not the case - the JWT var overwrote ENV vars. But we should retest that.

erisu commented 3 years ago

Closing out ticket since we are removing Travis CI and AppVeyor. SauceLabs & its JWT token will no longer be used.