search

apache / cordova-paramedic

Apache Cordova - Paramedic
https://cordova.apache.org/
Apache License 2.0
36 stars 53 forks source link

Investigate param `--ci`, `this.config.isCI` #168

Open janpio opened 5 years ago

janpio commented 5 years ago

Paramedic has a param --ci that can be read in code via this.config.isCI. There is also a connected plugin ci-plugin that seems to be used in connection. Looking through the code, there is also some "interesting" code that is run or not run depending on this parameter.

Should be investigated if this is useful, if so how, and if not if it can be removed.

janpio commented 5 years ago

https://github.com/apache/cordova-paramedic/blob/5b8d30613d0fcb7d9a9abf16dd69783e5932d5c9/lib/ParamedicApp.js#L98-L107 https://github.com/apache/cordova-paramedic/blob/5b8d30613d0fcb7d9a9abf16dd69783e5932d5c9/lib/ParamedicApp.js#L79-L81 https://github.com/apache/cordova-paramedic/blob/5b8d30613d0fcb7d9a9abf16dd69783e5932d5c9/lib/paramedic.js#L199-L201

janpio commented 5 years ago

Re snippet 1: That gradleBuilderFile doesn't exist any more, so probably not working. Re snippet 2: This plugin somehow tells other plugins they are running in CI. Not clear if used anywhere (most probably not by core plugins though) Re snippet 3: Deprecated plugin