search

apache / cordova-paramedic

Apache Cordova - Paramedic
https://cordova.apache.org/
Apache License 2.0
36 stars 53 forks source link

Investigate "monkey patching browser platform to disable browser pop-up" (Browser + Sauce) #170

Open janpio opened 5 years ago

janpio commented 5 years ago

https://github.com/apache/cordova-paramedic/blob/a1a8cb457adbf88680890a57de693215cd0658e7/lib/ParamedicApp.js#L107-L125

Not sure what exactly this does and if it is still needed.

janpio commented 5 years ago

Doesn't seem to work at least: https://travis-ci.org/apache/cordova-paramedic/jobs/552161338

cordova-paramedic: successfully finished adding platform browser
cordova-paramedic: I like patching stuff, so...
cordova-paramedic: monkey patching browser platform to disable browser pop-up.
cordova-paramedic: couldn't apply the patch. Not a big deal, though: things should work anyway.