apache / cordova-plugin-camera

Apache Cordova Plugin camera
https://cordova.apache.org/
Apache License 2.0
960 stars 1.52k forks source link

Update(android): android 13 camera open Fixed #839

Closed rokanraja1 closed 8 months ago

rokanraja1 commented 10 months ago

Platforms affected

Not Affected any Platform

Description

Android 13 camera not open issue

closes #840

Testing

I was checked Manually

Checklist

DUWENINK commented 9 months ago

why apache so slowly merge this ,I need it ,ばかやろ

rokanraja1 commented 8 months ago

On 21-Aug-2023 12:59 pm, Francesco @.***> wrote:

@spiderciccio commented on this pull request.


In src/android/CameraLauncher.javahttps://github.com/apache/cordova-plugin-camera/pull/839#discussion_r1299713366:

@@ -1312,20 +1312,39 @@ public void onScanCompleted(String path, Uri uri) { }

 public void onRequestPermissionResult(int requestCode, String[] permissions,

question: have you tested this line, because in my test in android 13 hasPermission is every time false, or you call a request to have permission, or remove this line(my android 13 worked without this if)

— Reply to this email directly, view it on GitHubhttps://github.com/apache/cordova-plugin-camera/pull/839#pullrequestreview-1586366355, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5WIOIEFJRK2IHVF2OBJUQDXWME4XANCNFSM6AAAAAA2LIFRYU. You are receiving this because you authored the thread.Message ID: @.***>

Maybe your camera permission is issue

breautek commented 8 months ago

This PR is superseded by Should be fixed by https://github.com/apache/cordova-plugin-camera/pull/844