search

apache / cordova-plugin-dialogs

Apache Cordova Dialogs Plugin
https://cordova.apache.org/
Apache License 2.0
288 stars 351 forks source link

[MAJOR] GH-28 Progress dialogs should not be cancellable outside the window #110

Open brodybits opened 5 years ago

brodybits commented 5 years ago

Proposal to cherry-pick the fix proposed in PR #28 without the whitespace fixes that are now part of PR #109. The change in behavior makes sense to me. I think this change should go into a new major release.

Resolves #28

janpio commented 5 years ago

Please update the PR to describe what the codee change actually does, or what the situation before was.

oliversalzburg commented 5 years ago

Pretty sure the change results in the dialogs not being cancellable by touching outside the dialog.

The problem, as I understand it, is that you can tap anywhere on the screen and thus cancel the dialog, which is almost always unintended for a progress indicator. This change fixes that.

janpio commented 5 years ago

So the PR title is still wrong, correct @oliversalzburg?

oliversalzburg commented 5 years ago

@janpio It is unless my interpretation of the change is wrong.

brodybits commented 5 years ago

I just corrected the title, thanks @oliversalzburg.