apache / cordova-plugin-dialogs

Apache Cordova Dialogs Plugin
https://cordova.apache.org/
Apache License 2.0
289 stars 354 forks source link

On iOS8+ allow this dialog to be presented from alternate web views. #57

Closed kurtisf closed 8 years ago

kurtisf commented 9 years ago
purplecabbage commented 9 years ago

No. InAppBrowser should not be able to call cordova native functions.

kurtisf commented 9 years ago

The use case is the app receives and event, such as a push notification while the InAppBrowser is presented. If you use this plugin (cordova-plugin-dialogs) to show an Alert to the user, it will throw an exception because it is trying to present on a different VC. Current this plugin cannot be used to present an alert if the InAppBrowser is also used.

On Fri, Sep 4, 2015 at 1:20 PM, Jesse MacFadyen notifications@github.com wrote:

No. InAppBrowser should not be able to call cordova native functions.

— Reply to this email directly or view it on GitHub https://github.com/apache/cordova-plugin-dialogs/pull/57#issuecomment-137843882 .

This email may contain confidential information for the sole use of the intended recipient(s). If you are not an intended recipient, please notify the sender and delete all copies immediately.

jcesarmobile commented 9 years ago

There is already a pull request for other issue that fixes this problem too https://github.com/apache/cordova-plugin-dialogs/pull/54

Justin-Credible commented 9 years ago

Same problem here. This is actually a problem for any plugin that shows a UIView (in my case the PayPal Mobile SDK).

If the dialog plugin is used to show an alert dialog while another view is present, the app will crash.

androdel commented 9 years ago

When will this fix be merged and released? Because this issue is blocking the release of my app.

jcesarmobile commented 9 years ago

If you are in a hurry you can use my fork installing from the git url

Justin-Credible commented 9 years ago

Any updates on this? Can we get this merged please?

jcesarmobile commented 9 years ago

should be fixed by https://github.com/apache/cordova-plugin-dialogs/pull/54 (already merged)

purplecabbage commented 9 years ago

Thanks. This has been addressed in #54. Closing.