allow programatically dismissing dialogs - Githubissues

apache / cordova-plugin-dialogs

Apache Cordova Dialogs Plugin

https://cordova.apache.org/

Apache License 2.0

290 stars 354 forks source link

allow programatically dismissing dialogs #79

Closed Slavrix closed 3 years ago

Slavrix commented 8 years ago

Platforms affected

What does this PR do?

What testing has been done on this change?

Checklist

[ ] ICLA has been signed and submitted to secretary@apache.org.
[ ] Reported an issue in the JIRA database
[ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.

cordova-qa commented 8 years ago

Cordova CI Build has one or more failures.

Commit - Link Dashboard - Link

Builder Name	Console Output	Test Report	Device Logs
Windows 8.1 Store	Link	Link	Link
Windows 10 Store	Link	Link	Link
Windows 8.1 Phone	Link	Link	Link
iOS	Link	Link	Link
Android Mac	Link	Link	Link

vladimir-kotikov commented 8 years ago

Let there be tests

cordova-qa commented 8 years ago

Cordova CI Build has completed successfully.

Commit - Link Dashboard - Link

Builder Name	Console Output	Test Report	Device Logs
Windows 8.1 Store	Link	Link	Link
Windows 10 Store	Link	Link	Link
Windows 8.1 Phone	Link	Link	Link
iOS	Link	Link	Link
Android Mac	Link	Link	Link

MacGritsch commented 6 years ago

Are there plans to pull these changes? Cancellable alerts are really handy!

dpa99c commented 3 years ago

This functionality has now been merged under #148 based on the initial work by @Slavrix - thanks for your effort on this.