search

apache / cordova-plugin-dialogs

Apache Cordova Dialogs Plugin
https://cordova.apache.org/
Apache License 2.0
290 stars 354 forks source link

added support for destructive Button on iOS #92

Closed kas84 closed 7 years ago

kas84 commented 7 years ago

Platforms affected

iOS

What does this PR do?

Adds UIAlertActionStyleDestructive support for buttons on iOS.

What testing has been done on this change?

Emulator testing on iOS.

kerrishotts commented 7 years ago

Please review the Cordova Contributor Guidelines, file a Jira issue and update this PR appropriately.

cordova-qa commented 7 years ago

Cordova CI Build has one or more failures.

Commit - Link Dashboard - Link

Builder Name Console Output Test Report Device Logs
Windows 10 Store Link Link Link
iOS 9.3 Link Link Link
iOS 10.0 Link Link Link
Android 4.4 Link Link Link
Android 5.1 Link Link Link
alsorokin commented 7 years ago

Let there be tests

jcesarmobile commented 7 years ago

A change like this should be documented. Also, we usually don't accept this kind of changes to only one platform, do you know if it's possible to use destructive button styles on other platforms?

I think it's more clear if you use destructiveButtonLabel instead of addDestructiveButtonWithLabel in the javascript and in some places of the .m like when you pick the command arguments.

cordova-qa commented 7 years ago

Cordova CI Build has completed successfully.

Commit - Link Dashboard - Link

Builder Name Console Output Test Report Device Logs
Windows 10 Store Link Link Link
iOS 9.3 Link Link Link
iOS 10.0 Link Link Link
Android 4.4 Link Link Link
Android 5.1 Link Link Link
filmaj commented 7 years ago

No answer from reporter, will close this down.