apache / cordova-plugin-file-transfer

Apache Cordova File Transfer Plugin
https://cordova.apache.org/
Apache License 2.0
597 stars 886 forks source link

CB-9837 Add data URI support to file-transfer upload on iOS #122

Closed daserge closed 8 years ago

daserge commented 8 years ago

Adds iOS and Windows implementation; mention in the docs Adds corresponding tests Increases spec.35 timeout for Windows Phone 8.1 case as it contains 2 download operations (it was occasionally failing on device)

Jira issue

dblotsky commented 8 years ago

Are base64-encoded files documented as supported by the file transfer API?

daserge commented 8 years ago

Updated the docs, thanks.

dblotsky commented 8 years ago

Thanks for documenting! What I mean is: is this a supported feature in the first place?

daserge commented 8 years ago

This fixes the manual test for camera plugin when DATA_URI output is selected and the file is uploaded via file-transfer so the scenario seems to be expected to work.

dblotsky commented 8 years ago

Ah, gotcha. Thanks for the explanation. If the tests pass, then it LGTM!