search

apache / cordova-plugin-file-transfer

Apache Cordova File Transfer Plugin
https://cordova.apache.org/
Apache License 2.0
596 stars 887 forks source link

CB-10782: Occasional failure in file transfer tests causing mobilespec crash #132

Closed sarangan12 closed 8 years ago

sarangan12 commented 8 years ago

This is one of the flaky tests that occurs about 20% of the times in windows store 8.1 platform. But, this has not been reproduced locally. This causes the app to crash. The error message is " Error: Expected a spy, but got Function." Based on the error message, I suspect that the error is related to the issue that the spying is not set correctly on the transfer progress. So, I have modified this code and submitting this for PR.

sarangan12 commented 8 years ago

@dblotsky @nikhilkh @riknoll Can you merge this PR?

riknoll commented 8 years ago

LGTM

daserge commented 8 years ago

@sarangan12, changing /* global describe, it, expect, beforeEach, afterEach, spyOn, jasmine, pending */ to /* jshint jasmine: true */ will probably fix the jshint checks failure.

dblotsky commented 8 years ago

LGTM.