search

apache / cordova-plugin-file-transfer

Apache Cordova File Transfer Plugin
https://cordova.apache.org/
Apache License 2.0
596 stars 887 forks source link

Removing the expectation in spec.34 for the transfer method to be called #135

Closed sarangan12 closed 8 years ago

sarangan12 commented 8 years ago

The expectation in this spec is causing the crash in the build process. The error message is "Expected Spy but got a function". This error will happen only if there is no spy on the function. But as you can see the spy is set and still we get the error.

In order to avoid the error, I am commenting out this expectation. I do not think this would have any adverse impact as we do check for the error code (to be aborted) and the presence of the file(the purpose of this spec). So, I am confident that we are not losing any functionality by commenting out this expectation.

@rakatyal @riknoll @omefire Can you please review and merge this PR?

omefire commented 8 years ago

LGTM!

omefire commented 8 years ago

Could you please append the JIRA number to the title of this PR ?