search

apache / cordova-plugin-file-transfer

Apache Cordova File Transfer Plugin
https://cordova.apache.org/
Apache License 2.0
596 stars 887 forks source link

added link to sample #145

Closed Mikejo5000 closed 8 years ago

nikhilkh commented 8 years ago

:shipit:

nikhilkh commented 8 years ago

Sounds like there is a conflict with master - @Mikejo5001 Could you please rebase? Your diff should only contain the line you added.

cordova-qa commented 8 years ago

Cordova CI Build has completed successfully.

Commit - Link Dashboard - Link

Builder Name Console Output Test Report Device Logs
Windows 8.1 Store Link Link Link
Windows 10 Store Link Link Link
Windows 8.1 Phone Link Link Link
iOS Link Link Link
Android Mac Link Link Link
nikhilkh commented 8 years ago

@daserge Can you please review and help merge?

daserge commented 8 years ago

LGTM, minor comments

nikhilkh commented 8 years ago

@daserge Thanks for your review - can you make the improvements you suggest and help merge this in.

daserge commented 8 years ago

Merged in https://github.com/apache/cordova-plugin-file-transfer/commit/82c5af9b5dd6accbd6b2d25174d3c1f4e576e5b3 @Mikejo5000 could you please close the PR?