CB-11497 Use cordova-vm for testing 304 errors - Githubissues

apache / cordova-plugin-file-transfer

Apache Cordova File Transfer Plugin

https://cordova.apache.org/

Apache License 2.0

596 stars 887 forks source link

CB-11497 Use cordova-vm for testing 304 errors #151

Closed vladimir-kotikov closed 8 years ago

vladimir-kotikov commented 8 years ago

Platforms affected

All

What does this PR do?

Replaces external Apache resource to cordova-vm one for HTTP 304 tests. This is needed to resolve intermittent spec 33 and 35 failures on iOS (see https://issues.apache.org/jira/browse/CB-11479 for details)

What testing has been done on this change?

Ran autotests via paramedic on all main platforms

Checklist

[X] ICLA has been signed and submitted to secretary@apache.org.
[X] Reported an issue in the JIRA database
[X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.

daserge commented 8 years ago

LGTM :+1:

Although it would be ideal to update the test server in terms of adding If-Modified-Since header tests.

cordova-qa commented 8 years ago

Cordova CI Build has completed successfully.

Commit - Link Dashboard - Link

Builder Name	Console Output	Test Report	Device Logs
Windows 8.1 Store	Link	Link	Link
Windows 10 Store	Link	Link	Link
Windows 8.1 Phone	Link	Link	Link
iOS	Link	Link	Link
Android	Link	Link	Link