apache / cordova-plugin-file-transfer

Apache Cordova File Transfer Plugin
https://cordova.apache.org/
Apache License 2.0
596 stars 887 forks source link

patch method #168

Closed theromis closed 6 years ago

theromis commented 7 years ago

We using Django Rest Framework, and it sending partial updates as a PATCH method. So the patch SHOULD be at list an option for this module.

cordova-qa commented 7 years ago

Cordova CI Build has one or more failures. Link: http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/44/

260 tests run, 24 skipped, 34 failed.

theromis commented 7 years ago

@shazron can somebody take care of this PR?

marcpursals commented 7 years ago

Hi, I'm really interested on using patch method. Is the brach enough stable to use it? Is there any scheduled time to get this functionality available on stable version?

Thanks in advance

theromis commented 7 years ago

@daserge @matrosov-nikita @alsorokin Can somebody take care of this PR?

marcpursals commented 7 years ago

Actually I did clone this branch and I'm using it. It works like a charm. So I'm freezing for next stable release. God job @theromis thanks.

purplecabbage commented 7 years ago

https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/PATCH LGTM!

shazron commented 7 years ago

This patch (pun, I know) needs a README update for httpMethod as well, to be complete.

maverickmishra commented 6 years ago

With the new features introduced in XMLHttpRequest, this plugin is not needed any more. Migrating from this plugin to using the new features of XMLHttpRequest, is explained in this Cordova blog post.