CB-12154 file-transfer progressEvent.total = -1 on iOS - Githubissues

apache / cordova-plugin-file-transfer

Apache Cordova File Transfer Plugin

https://cordova.apache.org/

Apache License 2.0

596 stars 887 forks source link

CB-12154 file-transfer progressEvent.total = -1 on iOS #170

Closed daserge closed 7 years ago

daserge commented 7 years ago

Platforms affected

iOS

What does this PR do?

Reverts logic for not setting Content-Length for chunkedMode=true. This was causing progress events total to be -1 and progress to be not computable. So while this change technically violates the specification it fixes the functionality.

What testing has been done on this change?

Manual and autotests.

Checklist

[x] Reported an issue in the JIRA database
[x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.

cordova-qa commented 7 years ago

Cordova CI Build has one or more failures. Link: http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/46/

312 tests run, 26 skipped, 50 failed.

erikramalho commented 7 years ago

+1 for to merge it ASAP! cheers @daserge

daserge commented 7 years ago

@jcesarmobile, @shazron, @stevengill could you please take a look?

erikramalho commented 7 years ago

I've tested @daserge commit and it works perfectly! please, merge it asap!

cordova-qa commented 7 years ago

Cordova CI Build has one or more failures. Link: http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/47/

312 tests run, 26 skipped, 50 failed.