CB-12745: Adding support for non base64 encoded data-URIs - Githubissues

apache / cordova-plugin-file-transfer

Apache Cordova File Transfer Plugin

https://cordova.apache.org/

Apache License 2.0

598 stars 885 forks source link

CB-12745: Adding support for non base64 encoded data-URIs #178

Closed Viras- closed 6 years ago

Viras- commented 7 years ago

Platforms affected

iOS, windows

What does this PR do?

Adding support for non base64 encoded data-URIs

What testing has been done on this change?

Tested on iOS Simulator and real App Tested on Windows 10 machine

Checklist

[x] Reported an issue in the JIRA database
[X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[x] Added automated test coverage as appropriate for this change. (no test changes required)

cordova-qa commented 7 years ago

Cordova CI Build has completed successfully.

Commit - Link Dashboard - Link

318 tests run, 15 skipped, 0 failed.

cordova-qa commented 7 years ago

Cordova CI Build has completed successfully.

Commit - Link Dashboard - Link

318 tests run, 15 skipped, 0 failed.

maverickmishra commented 6 years ago

With the new features introduced in XMLHttpRequest, this plugin is not needed any more. Migrating from this plugin to using the new features of XMLHttpRequest, is explained in this Cordova blog post.

Viras- commented 6 years ago

This is very sad - especially since the XHR object still lacks support for setting some custom headers (e.g. the Referer header). This can be done using the FileTransfer plugin and I think this plugin should not be obsoleted.